Clean up deprecated .copyDst/.renderable/.renderTarget* from kTextureFormatInfo #3412
+42
−166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kainino0x
force-pushed
the
textureinfo2part6
branch
from
e3e9c55 to
ef07182
Compare
kainino0x
force-pushed
the
textureinfo2part6
branch
5 times, most recently
from
1913edc to
52692b1
Compare
.renderTargetComponentAlignment = .colorRender.alignment .renderTargetPixelByteCost = .colorRender.byteCost The one exception to this is rg11b10ufloat, which is not renderable in core, but has an extension for renderability. kTextureFormatInfo currently only expresses core capabilities. The alignment and byteCost for this format will need to be added back when the refactor is done to make a table for "static" properties of texture formats (which never vary based on capabilities) - shape of that refactor is TBD.
kainino0x
force-pushed
the
textureinfo2part6
branch
from
52692b1 to
fb77f4b
Compare
|
PTAL |
lokokung
approved these changes
Mar 11, 2024
ben-clayton
pushed a commit
to ben-clayton/cts
that referenced
this pull request
Mar 18, 2024
…FormatInfo (gpuweb#3412) * Refactor deprecated .copyDst/.renderable in texture_zero_init_test.ts * Remove no-op use of .renderable in texture_zero_init_test.ts * Refactor deprecated .renderable in createTexture.spec.ts * Remove deprecated .copyDst * Remove deprecated .renderable * Remove unused .renderTarget{ComponentAlignment,PixelByteCost} .renderTargetComponentAlignment = .colorRender.alignment .renderTargetPixelByteCost = .colorRender.byteCost The one exception to this is rg11b10ufloat, which is not renderable in core, but has an extension for renderability. kTextureFormatInfo currently only expresses core capabilities. The alignment and byteCost for this format will need to be added back when the refactor is done to make a table for "static" properties of texture formats (which never vary based on capabilities) - shape of that refactor is TBD. * Refactor trivial uses of deprecated .bytesPerBlock
kainino0x
added a commit
to kainino0x/cts
that referenced
this pull request
Mar 18, 2024
Broken in gpuweb#3412. Prior to this, some checks were being skipped (that we didn't want to skip, but were skipped because of the limitations of the format info table).
8 tasks
kainino0x
added a commit
that referenced
this pull request
Mar 18, 2024
Broken in #3412. Prior to this, some copies were being skipped for some formats because bytesPerBlock was undefined for those copies. This doesn't change the coverage of the test though, as the actual check that used those copies is still skipped. I missed the regressions before because they were a bit buried in existing failures on my machine.
ben-clayton
pushed a commit
to ben-clayton/cts
that referenced
this pull request
Mar 18, 2024
Broken in gpuweb#3412. Prior to this, some copies were being skipped for some formats because bytesPerBlock was undefined for those copies. This doesn't change the coverage of the test though, as the actual check that used those copies is still skipped. I missed the regressions before because they were a bit buried in existing failures on my machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus the trivial cases of the deprecated
.bytesPerBlock.Part 6 of Issue: #2495
Requirements for PR author:
.unimplemented()./** documented */and new helper files are found inhelper_index.txt.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.